Priv fields #9969
Priv fields #9969
Conversation
src/libextra/arc.rs
Outdated
There was a problem hiding this comment.
None of these comments are necessary since we (the reviewers) can see exactly what you changed from the diff (this view).
Can you remove them please?
|
Thank you for this, it looks pretty good! I'd like the removal of the comments like Also, this needs to be rebased on top of the master branch of the mozilla/rust repo. |
src/libextra/url.rs
Outdated
There was a problem hiding this comment.
I have a feeling that these are designed for use outside this module (but I'm not sure).
If they are, then the should still be public.
There was a problem hiding this comment.
Ok, I just checked in servo, and it does use the fields directly, so these need to be public. (git checkout src/libextra/url.rs should work.)
|
I removed unnecessary comments and white spaces and changed some fields to public as suggested in above comments . |
src/libextra/arc.rs
Outdated
src/libstd/fmt/rt.rs
Outdated
|
It's almost ready to go! :) Although it still needs to be rebased. (cc @catamorphism.) |
|
@reedlepee123 You'll need to rebase and fix the merge conflicts before we can approve this. Find either myself or tjc on IRC if you would like some instruction on how to do this. |
|
This closes #4386. |
5 participants
No description provided.